ryukobayashi commented on code in PR #5487:
URL: https://github.com/apache/hive/pull/5487#discussion_r1792745201
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java:
##########
@@ -49,20 +47,29 @@ public static IDriver newDriver(QueryState queryState,
QueryInfo queryInfo) {
}
String strategies =
queryState.getConf().getVar(ConfVars.HIVE_QUERY_REEXECUTION_STRATEGIES);
- strategies = Strings.nullToEmpty(strategies).trim().toLowerCase();
List<IReExecutionPlugin> plugins = new ArrayList<>();
for (String string : strategies.split(",")) {
if (string.trim().isEmpty()) {
continue;
}
- plugins.add(buildReExecPlugin(string));
+
+ IReExecutionPlugin plugin = buildReExecPlugin(string);
+ if (plugin != null) {
+ plugins.add(buildReExecPlugin(string));
+ } else {
+ plugins.add(buildCustomReExecPlugin(string));
+ }
}
return new ReExecDriver(queryState, queryInfo, plugins);
}
private static IReExecutionPlugin buildReExecPlugin(String name) throws
RuntimeException {
Class<? extends IReExecutionPlugin> pluginType =
ReExecutionStrategyType.getPluginClassByName(name);
Review Comment:
OK, I will remove trim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
