okumin commented on code in PR #5452:
URL: https://github.com/apache/hive/pull/5452#discussion_r1804668198
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -809,6 +809,10 @@ public static enum ConfVars {
HIVE_IN_TEST_REPL("hive.in.repl.test", false, "internal usage only, true
in replication test mode", true),
HIVE_IN_TEST_IDE("hive.in.ide.test", false, "internal usage only, true if
test running in ide",
true),
+
HIVE_IN_TEST_PLANMAPPER_STRICT_VALIDATION("hive.in.test.planmapper.strict.validation",
false,
+ "internal use only, whether to raise an error when unexpected links
are found. We ignore equivalence mapping "
+ + "violation because it introduces only minor problems. But we want to
strictly check it in qtest so that we "
+ + "can prevent further degradations"),
Review Comment:
Thanks. Let's say our qtest covers 99.9% of use cases of Hive(I trust the
coverage 😃 ), which means 0.1% are uncovered. I assume we agreed that it is too
costly to achieve 100% promptly.
I personally thought it'd be more reasonable to use CI if we wanted to keep
the stability high enough, e.g. 90%. I'm a bit pessimistic here and I'm going
to remove this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
