soumyakanti3578 commented on code in PR #5494:
URL: https://github.com/apache/hive/pull/5494#discussion_r1805482875


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCExpandExpressionsRule.java:
##########
@@ -178,6 +177,9 @@ protected static class RexTransformIntoOrAndClause extends 
RexShuttle {
     @Override
     public RexNode visitCall(RexCall inputCall) {
       RexNode node = super.visitCall(inputCall);
+      if (!RexUtil.isFlat(node)) {
+        node = RexUtil.flatten(rexBuilder, node);
+      }

Review Comment:
   Although it is doing the same thing, this indeed looks safer, so I have 
included it in the latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to