deniskuzZ commented on code in PR #5503:
URL: https://github.com/apache/hive/pull/5503#discussion_r1806158275
##########
itests/qtest-iceberg/src/test/java/org/apache/hadoop/hive/cli/TestIcebergLlapLocalCompactorCliDriver.java:
##########
@@ -41,6 +41,8 @@ public class TestIcebergLlapLocalCompactorCliDriver {
static CliAdapter adapter = new
CliConfigs.IcebergLlapLocalCompactorCliConfig().getCliAdapter();
private static final AtomicBoolean stop = new AtomicBoolean();
+ private static final String defaultPoolName = null;
+ private static final String icebergPoolName = "iceberg";
Review Comment:
minor: please check
https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=5503&id=apache_hive&open=AZJ6FzB-hMQv6qrxfwyh
final vars should be all uppercase with underscore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
