deniskuzZ commented on code in PR #5483:
URL: https://github.com/apache/hive/pull/5483#discussion_r1808281964
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2098,9 +2098,10 @@ public boolean
canPerformMetadataDelete(org.apache.hadoop.hive.ql.metadata.Table
}
@Override
- public List<FieldSchema>
getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
+ public List<FieldSchema>
getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Table hmsTable, boolean
latestSpecOnly) {
Table icebergTable = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
- return IcebergTableUtil.getPartitionKeys(icebergTable,
icebergTable.spec().specId());
+ return latestSpecOnly ? IcebergTableUtil.getPartitionKeys(icebergTable,
true) :
Review Comment:
why do you need ternary operator here?
````IcebergTableUtil.getPartitionKeys(icebergTable, latestSpecOnly)````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
