zabetak commented on code in PR #5497:
URL: https://github.com/apache/hive/pull/5497#discussion_r1810495489
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java:
##########
@@ -421,13 +420,7 @@ private static RelNode createMaterializedViewScan(HiveConf
conf, Table viewTable
}
// 1.3 Build row type from field <type, name>
- RelDataType rowType;
- try {
- rowType = TypeConverter.getType(cluster, rr, null);
- } catch (CalciteSemanticException e) {
- // Bail out
- return null;
- }
+ RelDataType rowType = TypeConverter.getType(cluster, rr, null);
Review Comment:
`CalciteSemanticException` is a checked exception so we were forced to catch
and handle it here. However, after the changes in this PR it can't be thrown
anymore from `TypeConverter.getType` methods because we are able to handle all
type conversions.
The caller will never get back null as a result so it doesn't need to handle
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
