zabetak commented on code in PR #5476:
URL: https://github.com/apache/hive/pull/5476#discussion_r1810632477


##########
pom.xml:
##########
@@ -92,7 +92,7 @@
     <test.excludes.additional/>
     <!-- Plugin and Plugin Dependency Versions -->
     <ant.contrib.version>1.0b3</ant.contrib.version>
-    <maven.test.jvm.args>-Xmx2048m 
-DJETTY_AVAILABLE_PROCESSORS=4</maven.test.jvm.args>
+    <maven.test.jvm.args>-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4 
-Duser.country=US</maven.test.jvm.args>

Review Comment:
   According to the comments above it seems that setting the `LANG` environment 
variable is not something that works on every system and that's why you opted 
to use the `user.country` property. For future reference, can you please give 
an example of a system where setting the `LANG` variable does not work.
   
   Other than that the changes LGTM, and we can merge this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to