deniskuzZ commented on code in PR #5215:
URL: https://github.com/apache/hive/pull/5215#discussion_r1815370139
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -461,44 +460,46 @@ public void
appendFiles(org.apache.hadoop.hive.metastore.api.Table table, URI fr
}
@Override
- public Map<String, String> getBasicStatistics(Partish partish) {
- org.apache.hadoop.hive.ql.metadata.Table hmsTable = partish.getTable();
+ public Map<String, String>
getBasicStatistics(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
Review Comment:
please don't change the method signature. it would be used in a follow-up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
