zhangbutao commented on code in PR #5215:
URL: https://github.com/apache/hive/pull/5215#discussion_r1816098208
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##########
@@ -518,11 +518,11 @@ public static Path getDumpPath(Path root, String dbName,
String tableName) {
}
public static String getTableSnapshotRef(String refName) {
- Matcher ref = SNAPSHOT_REF.matcher(refName);
- if (ref.matches()) {
- return ref.group(1);
+ if (org.apache.commons.lang3.StringUtils.isEmpty(refName)) {
Review Comment:
Good!
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -248,7 +248,12 @@ default Map<String, String>
getOperatorDescProperties(OperatorDesc operatorDesc,
* @param partish a partish wrapper class
* @return map of basic statistics, can be null
*/
+ @Deprecated
default Map<String, String> getBasicStatistics(Partish partish) {
+ return getBasicStatistics(partish.getTable());
+ }
+
+ default Map<String, String>
getBasicStatistics(org.apache.hadoop.hive.ql.metadata.Table table) {
Review Comment:
ok
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -559,4 +566,32 @@ public static List<String> getPartitionNames(Table
icebergTable, Map<String, Str
throw new SemanticException(String.format("Error while fetching the
partitions due to: %s", e));
}
}
+
+ public static Snapshot
getSpecificSnapshot(org.apache.hadoop.hive.ql.metadata.Table hmsTable, Table
table) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
