deniskuzZ commented on code in PR #5205:
URL: https://github.com/apache/hive/pull/5205#discussion_r1820340259
##########
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java:
##########
@@ -44,14 +44,12 @@
* Test CLI service with a retrying client. All tests should pass. This is to
validate that calls
* are transferred successfully.
*/
-public class TestRetryingThriftCLIServiceClient {
+public class TestRetryingThriftCLIServiceClient extends AbstractThriftCLITest {
protected static ThriftCLIService service;
- private HiveConf hiveConf;
- private HiveServer2 server;
- @Before
- public void init() {
- hiveConf = new HiveConf();
+ @BeforeClass
+ public void init() throws Exception {
Review Comment:
also please check the reported sonar issues
- redundant throws,
- can we do something better than thread sleep, maybe not in this PR
https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5205&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
