difin commented on code in PR #5515:
URL: https://github.com/apache/hive/pull/5515#discussion_r1821286583
##########
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java:
##########
@@ -384,7 +384,7 @@ public static PrimitiveTypeEntry
getTypeEntryFromPrimitiveWritableClass(
* Get the TypeEntry for the given base type name (int, varchar, etc).
*/
public static PrimitiveTypeEntry getTypeEntryFromTypeName(String typeName) {
- return typeNameToTypeEntry.get(typeName);
+ return typeNameToTypeEntry.get(typeName.toLowerCase());
Review Comment:
> The changes proposed in this pull request aim to make the SerDe API
case-insensitive for the data type "string".
This change seems to affect all primitive type and not only "string" type.
Can this cause any problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
