deniskuzZ commented on code in PR #5520:
URL: https://github.com/apache/hive/pull/5520#discussion_r1823287318
##########
service/src/java/org/apache/hive/service/cli/HiveSQLException.java:
##########
@@ -150,4 +189,19 @@ public static TStatus toTStatus(Exception e) {
return tStatus;
}
+ private static String addQueryId(String message, QueryState queryState) {
+ boolean opLogEnabled = HiveConf.getBoolVar(queryState.getConf(),
+ HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_ENABLED, false);
+ String opLogLevel = HiveConf.getVar(queryState.getConf(),
+ HiveConf.ConfVars.HIVE_SERVER2_LOGGING_OPERATION_LEVEL,
StringUtils.EMPTY);
+ boolean asyncCompile = HiveConf.getBoolVar(queryState.getConf(),
+ HiveConf.ConfVars.HIVE_SERVER2_ASYNC_EXEC_ASYNC_COMPILE, false);
+
+ if ((!opLogEnabled ||
opLogLevel.equals(OperationLog.LoggingLevel.NONE.name()) || !asyncCompile) &&
Review Comment:
1. what is with `asyncCompile`? we return the operation log regardless if
it's enabled?
2. why are we checking if the message doesn't contain QUERY_ID pattern? What
if some exceptions do and we still want to get the operation log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
