deniskuzZ commented on code in PR #5474:
URL: https://github.com/apache/hive/pull/5474#discussion_r1823344623
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -83,6 +88,16 @@ protected DatabaseProduct() {}
public static final String ORACLE_NAME = "oracle";
public static final String UNDEFINED_NAME = "other";
+ public static DatabaseProduct determineDatabaseProduct(DataSource connPool,
+ Configuration conf) {
+ try (Connection conn = connPool.getConnection()) {
+ String s = conn.getMetaData().getDatabaseProductName();
+ return determineDatabaseProduct(s, conf);
+ } catch (SQLException e) {
+ throw new RuntimeException("Unable to get database product name", e);
Review Comment:
can we throw `IllegalStateException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
