okumin commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1824714705
##########
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:
##########
@@ -260,6 +275,18 @@ public byte[] getBytesForHash() {
return allBytes;
}
}
+
+ public byte[] getBytesForIdentity() {
Review Comment:
Renamed.
https://github.com/apache/hive/pull/5409/commits/6de1cf7be0d724877fc2cf98a00fb95f138d8924
BTW, do you know why we shift the offset
[here](https://github.com/apache/hive/blob/6de1cf7be0d724877fc2cf98a00fb95f138d8924/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L274)?
If we can remove the `>> 3` or we are sure we can distinguish splits even with
`>> 3`, we can simply use `getBytesForHash`. If we are not sure, I think we can
keep this method for now for safety
```
SerDeUtils.writeLong(allBytes, pathBytes.length, getStart() >> 3);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
