ayushtkn commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830448474
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
was this test not running earlier?
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -50,6 +54,12 @@
public class TestGetPartitionAuthWithBatches {
+ @ClassRule
+ public static HiveTestEnvSetup env_setup = new HiveTestEnvSetup();
+
+ @Rule
+ public TestRule methodRule = env_setup.getMethodRule();
+
Review Comment:
I see these being added at multiple places, any pointers why it is needed in
the scope of surefire upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
