abstractdog commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1832593758
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -1072,7 +1073,9 @@ public Allocator getAllocator() {
@Override
public void close() throws IOException {
- // Noop: orcDataReaderRef is owned by the parent object
+ if (orcReader != null){
Review Comment:
yikes, in this I need to figure out whose parent is who :) ... and close
from the parent, because while cluster testing, a socket leak was removed by
closing the orc reader, so there is a problem with the current implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
