difin commented on code in PR #5527: URL: https://github.com/apache/hive/pull/5527#discussion_r1835800482
########## serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java: ########## @@ -1652,4 +1654,20 @@ public static boolean hasAllFieldsSettable(ObjectInspector oi, private ObjectInspectorUtils() { // prevent instantiation } + + /** + * Returns slot value used for ordering the fields to make it deterministic + * @param field : field of a given class + * @return + */ + private static int getSlotValue(Field field) { + try { + Field slotField = Field.class.getDeclaredField("slot"); + slotField.setAccessible(true); Review Comment: Yes, looks good to me (LGTM). I will be able to merge your changes in a few days, and in the meanwhile let's see if your change gets more reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org