harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837187071
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -531,6 +531,15 @@ private void cleanupReaders() {
// Ignore.
}
}
+
+ if (orcReader != null) {
Review Comment:
stop gets invoked in LlapRecordReader.close, but since its another thread,
we cannot close there so it has to be done in callInternal (same thread), and
since callInternal is only invoked once per OrcEncodedDataReader(confirmed by
Denys), changing code to do this in a try finally inside callInternal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
