zratkai commented on code in PR #5529:
URL: https://github.com/apache/hive/pull/5529#discussion_r1842223905
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -458,6 +458,52 @@ public static List<DeleteFile> getDeleteFiles(Table table,
String partitionPath)
t -> ((PositionDeletesScanTask) t).file()));
}
+ public static float getFileSizeRatio(Table table, String partitionPath, long
fileSizeInBytesThreshold) {
+ long uncompactedFilesCount = getDataFileCount(table, partitionPath,
fileSizeInBytesThreshold, true);
+ long compactedFilesCount = getDataFileCount(table, partitionPath,
fileSizeInBytesThreshold, false);
Review Comment:
Why the fileSizeInBytesThreshold is the comparator if a file is uncompacted
or compacted?
Isn't there a better approach to make this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
