KiranVelumuri commented on code in PR #5525:
URL: https://github.com/apache/hive/pull/5525#discussion_r1842392708


##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/MySQLExternalDB.java:
##########
@@ -53,7 +53,7 @@ public String[] getDockerAdditionalArgs() {
     }
 
     public boolean isContainerReady(ProcessResults pr) {
-        Pattern pat = Pattern.compile("ready for connections");
+        Pattern pat = Pattern.compile("mysqld.*ready for 
connections.*port.*3306");

Review Comment:
   Yes. This is to ensure we are checking for the right message in the logs.
   
   ```
   {"log":"2024-10-30T08:33:26.279974Z 0 [System] [MY-011323] [Server] X Plugin 
ready for connections. Socket: 
/var/run/mysqld/mysqlx.sock\n","stream":"stderr","time":"2024-10-30T08:33:26.280094471Z"}
   {"log":"2024-10-30T08:33:26.280002Z 0 [System] [MY-010931] [Server] 
/usr/sbin/mysqld: ready for connections. Version: '8.4.3'  socket: 
'/var/run/mysqld/mysqld.sock'  port: 0  MySQL Community Server - 
GPL.\n","stream":"stderr","time":"2024-10-30T08:33:26.280113388Z"}
   {"log":"2024-10-30 08:33:26+00:00 [Note] [Entrypoint]: Temporary server 
started.\n","stream":"stdout","time":"2024-10-30T08:33:26.286414721Z"}
   {"log":"'/var/lib/mysql/mysql.sock' -\u003e 
'/var/run/mysqld/mysqld.sock'\n","stream":"stdout","time":"2024-10-30T08:33:26.300903513Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/iso3166.tab' as time 
zone. Skipping it.\n","stream":"stderr","time":"2024-10-30T08:33:26.633191138Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/leap-seconds.list' as 
time zone. Skipping 
it.\n","stream":"stderr","time":"2024-10-30T08:33:26.633206472Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/leapseconds' as time 
zone. Skipping it.\n","stream":"stderr","time":"2024-10-30T08:33:26.633209013Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/tzdata.zi' as time 
zone. Skipping it.\n","stream":"stderr","time":"2024-10-30T08:33:27.32216068Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/zone.tab' as time zone. 
Skipping it.\n","stream":"stderr","time":"2024-10-30T08:33:27.322174472Z"}
   {"log":"Warning: Unable to load '/usr/share/zoneinfo/zone1970.tab' as time 
zone. Skipping it.\n","stream":"stderr","time":"2024-10-30T08:33:27.322175972Z"}
   {"log":"\n","stream":"stdout","time":"2024-10-30T08:33:27.376134889Z"}
   {"log":"2024-10-30 08:33:27+00:00 [Note] [Entrypoint]: Stopping temporary 
server\n","stream":"stdout","time":"2024-10-30T08:33:27.376908972Z"}
   {"log":"2024-10-30T08:33:27.382707Z 10 [System] [MY-013172] [Server] 
Received SHUTDOWN from user root. Shutting down mysqld (Version: 
8.4.3).\n","stream":"stderr","time":"2024-10-30T08:33:27.382850055Z"}
   {"log":"2024-10-30T08:33:28.731418Z 0 [System] [MY-010910] [Server] 
/usr/sbin/mysqld: Shutdown complete (mysqld 8.4.3)  MySQL Community Server - 
GPL.\n","stream":"stderr","time":"2024-10-30T08:33:28.731688667Z"}
   {"log":"2024-10-30T08:33:28.731448Z 0 [System] [MY-015016] [Server] MySQL 
Server - end.\n","stream":"stderr","time":"2024-10-30T08:33:28.731724083Z"}
   {"log":"2024-10-30 08:33:29+00:00 [Note] [Entrypoint]: Temporary server 
stopped\n","stream":"stdout","time":"2024-10-30T08:33:29.39841875Z"}
   {"log":"\n","stream":"stdout","time":"2024-10-30T08:33:29.3984735Z"}
   {"log":"2024-10-30 08:33:29+00:00 [Note] [Entrypoint]: MySQL init process 
done. Ready for start 
up.\n","stream":"stdout","time":"2024-10-30T08:33:29.400004417Z"}
   {"log":"\n","stream":"stdout","time":"2024-10-30T08:33:29.400021542Z"}
   {"log":"2024-10-30T08:33:29.416864Z 0 [System] [MY-015015] [Server] MySQL 
Server - start.\n","stream":"stderr","time":"2024-10-30T08:33:29.564124084Z"}
   {"log":"2024-10-30T08:33:29.562577Z 0 [System] [MY-010116] [Server] 
/usr/sbin/mysqld (mysqld 8.4.3) starting as process 
1\n","stream":"stderr","time":"2024-10-30T08:33:29.56413925Z"}
   {"log":"2024-10-30T08:33:29.566298Z 1 [System] [MY-013576] [InnoDB] InnoDB 
initialization has 
started.\n","stream":"stderr","time":"2024-10-30T08:33:29.566368625Z"}
   {"log":"2024-10-30T08:33:29.659047Z 1 [System] [MY-013577] [InnoDB] InnoDB 
initialization has 
ended.\n","stream":"stderr","time":"2024-10-30T08:33:29.659144Z"}
   {"log":"2024-10-30T08:33:29.796789Z 0 [Warning] [MY-010068] [Server] CA 
certificate ca.pem is self 
signed.\n","stream":"stderr","time":"2024-10-30T08:33:29.7968935Z"}
   {"log":"2024-10-30T08:33:29.796812Z 0 [System] [MY-013602] [Server] Channel 
mysql_main configured to support TLS. Encrypted connections are now supported 
for this channel.\n","stream":"stderr","time":"2024-10-30T08:33:29.796910917Z"}
   {"log":"2024-10-30T08:33:29.799079Z 0 [Warning] [MY-011810] [Server] 
Insecure configuration for --pid-file: Location '/var/run/mysqld' in the path 
is accessible to all OS users. Consider choosing a different 
directory.\n","stream":"stderr","time":"2024-10-30T08:33:29.799134209Z"}
   {"log":"2024-10-30T08:33:29.808028Z 0 [System] [MY-011323] [Server] X Plugin 
ready for connections. Bind-address: '::' port: 33060, socket: 
/var/run/mysqld/mysqlx.sock\n","stream":"stderr","time":"2024-10-30T08:33:29.808157Z"}
   {"log":"2024-10-30T08:33:29.808066Z 0 [System] [MY-010931] [Server] 
/usr/sbin/mysqld: ready for connections. Version: '8.4.3'  socket: 
'/var/run/mysqld/mysqld.sock'  port: 3306  MySQL Community Server - 
GPL.\n","stream":"stderr","time":"2024-10-30T08:33:29.808229042Z"}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to