ngsg commented on PR #5543: URL: https://github.com/apache/hive/pull/5543#issuecomment-2493236665
@zabetak The null values in `BytesColumnVector` come from ORC code. In the ORC code, ORC reader reset only `vector[]`. [ORC code1](https://github.com/apache/orc/blob/9699c4cbc50bbcc13a5c61623c01763c8b9507c5/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L2326-L2328) And if the new `ColumnVector` has `isRepeating=true`, the reader updates the first item only. [ORC code2](https://github.com/apache/orc/blob/9699c4cbc50bbcc13a5c61623c01763c8b9507c5/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L2390-L2396) So the previously used `start[]` and `length[]` are not updated nor reset. In my opinion, these null values are not a problem because it seems that `isRepeating=true` indicates that only `vector[0]` is valid and the other entries should be ignored. https://github.com/apache/hive/blob/afe05b968026dfdda631de1e2b090665f0820ef3/storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java#L71-L75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
