deniskuzZ commented on code in PR #5550:
URL: https://github.com/apache/hive/pull/5550#discussion_r1857274339
##########
serde/src/java/org/apache/hadoop/hive/serde2/json/HiveJsonReader.java:
##########
@@ -397,7 +400,11 @@ private Object visitLeafNode(final JsonNode leafNode,
case LONG:
return Long.valueOf(leafNode.asLong());
case BOOLEAN:
- return Boolean.valueOf(leafNode.asBoolean());
+ if ("false".equalsIgnoreCase(leafNode.asText())) {
Review Comment:
why do we need a string match here, won't the
`Boolean.valueOf(leafNode.asBoolean(true))` handle both cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
