BsoBird commented on code in PR #5562:
URL: https://github.com/apache/hive/pull/5562#discussion_r1859755305
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/mapjoin/MapJoinMemoryExhaustionHandler.java:
##########
@@ -96,7 +96,12 @@ public void checkMemoryStatus(long tableContainerSize, long
numRows)
+ tableContainerSize + "\tMemory usage:\t" + usedMemory +
"\tpercentage:\t" + percentageNumberFormat.format(percentage);
console.printInfo(msg);
if(percentage > maxMemoryUsage) {
- throw new MapJoinMemoryExhaustionError(msg);
+ System.gc();
Review Comment:
@zhangbutao @okumin
As a whole, this patch doesn't change any execution logic, it just rechecks
the memory space after trying to call system.gc() once in case of out-of-memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
