abstractdog commented on PR #5566: URL: https://github.com/apache/hive/pull/5566#issuecomment-2505615545
the fix looks good, I think we do bad things to the resource map in general :) can you please add a unit test? I don't insist on doing the whole scenario, but somethng like: 1. you can use TestDriver (it already has examples) 2. start SessionState 3. put a value in resourcemap, assert that value exists 4. call Driver.closeInProcess (you can open it for package-protected @VisibleForTesting if needed) 5. assert that the value in resourcemap is not present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
