okumin commented on code in PR #5556:
URL: https://github.com/apache/hive/pull/5556#discussion_r1862171239
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java:
##########
@@ -220,14 +220,14 @@ public Statistics clone() {
}
public void addBasicStats(Statistics stats) {
- dataSize += stats.dataSize;
+ dataSize = StatsUtils.safeAdd(dataSize, stats.dataSize);
numRows += stats.numRows;
Review Comment:
Can we also use `safeAdd` here? [This line in the same
file](https://github.com/apache/hive/blob/4654aea51b3369d7845ab129ece496672979fee9/ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java#L258)
does have a possibility of overflow. I know # of rows is unlikely to be
overflowed, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
