Aggarwal-Raghav commented on code in PR #5568:
URL: https://github.com/apache/hive/pull/5568#discussion_r1868785747
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -1636,6 +1636,9 @@ public static String getPartitionName(Path tablePath,
Path partitionPath, Set<St
public static String getNormalisedPartitionValue(String partitionValue,
String type) {
+ if (partitionValue.equals("__HIVE_DEFAULT_PARTITION__"))
Review Comment:
@ngsg, thanks for reviewing the PR. Yes, the issue is regarding
`hive.exec.default.partition.name`. As hive-common is not a dependency in
_standalone-metastore/metastore-server/pom.xml_ , i think it better to use
MetaConf as done in `getPartitionListByFilterExp`
https://github.com/apache/hive/blob/2ff3ed6d83a1633d17bbf5b3c852b34b51548ef8/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java#L270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
