okumin commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1869373366
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1840,6 +1841,14 @@ tableImplBuckets
-> ^(TOK_ALTERTABLE_BUCKETS $num)
;
+tableWriteOrdered
+@init { pushMsg("table sorted specification", state); }
+@after { popMsg(state); }
+ :
+ KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList
Review Comment:
Disclaimer: I might not be understanding the intention of this PR.
Is the semantics of the sort order of Iceberg different from that of Hive's
SORTED BY of bucketed sorted tables? If it is the same, we may use it. Maybe,
it is different. I also feel the global ordering is hard to achieve with the
current Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]