abstractdog commented on code in PR #5559:
URL: https://github.com/apache/hive/pull/5559#discussion_r1872947744
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:
##########
@@ -280,6 +280,7 @@ public int monitorExecution() {
// best effort
}
console.printError("Execution has failed. stack trace: " +
ExceptionUtils.getStackTrace(e));
+ diagnostics.append(e.getMessage());
Review Comment:
while I find this very useful, a bit confused why it's needed, is there a
chance you can repro a failure to see how is the error messages are handled?
I mean:
https://github.com/apache/hive/blob/cf83d4751271622a9a700c6f2330dbfff38801d2/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java#L296
so in the finally block, the final dagStatus (given by the tez am) also
contains diagnostics, which is then printed to the console and also added to
diagnostics
so this change assumes that there is an error which is swallowed here and is
not part of the final dagStatus
if that's the case, it's okay append to the diagnostics, we need to just
understand what happened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
