Aggarwal-Raghav commented on code in PR #5568:
URL: https://github.com/apache/hive/pull/5568#discussion_r1875735238
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -1636,6 +1637,10 @@ public static String getPartitionName(Path tablePath,
Path partitionPath, Set<St
public static String getNormalisedPartitionValue(String partitionValue,
String type) {
+ if (!NumberUtils.isParsable(partitionValue)) {
+ return partitionValue;
+ }
Review Comment:
@okumin , thanks for the input. I think there is already a UT for this and
passing post the patch. Please check
https://github.com/apache/hive/blob/0e75930d619e96a32ae35b59df9eeeb6466ea2c6/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java#L965
Let me know if I am missing something, but
**NumberUtils.isParsable(partitionValue)** will return true for a decimal and
later in same function it will be handled.
https://github.com/apache/hive/blob/0e75930d619e96a32ae35b59df9eeeb6466ea2c6/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java#L1653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
