zhangbutao commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1879470783
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1840,6 +1841,14 @@ tableImplBuckets
-> ^(TOK_ALTERTABLE_BUCKETS $num)
;
+tableWriteOrdered
+@init { pushMsg("table sorted specification", state); }
+@after { popMsg(state); }
+ :
+ KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList
Review Comment:
@zratkai you have created the ticket
[HIVE-28587](https://issues.apache.org/jira/browse/HIVE-28587), which means
that you will implement the `alter table `syntax like spark syntax.
https://iceberg.apache.org/docs/1.7.0/spark-ddl/#alter-table-write-ordered-by
Right?
> This syntax comes from the official Iceberg recommendation, which is for
alter table, and to be consistend I modified the ALTER to CREATE in the syntax,
so at CREATE table it is the same as ALTER TABLE:
I already know why you give this create syntax. But since there is no
uniform `Create `syntax for the `write order`, i think we no need to make
`Create `syntax to be consistend with the `Alter `syntax. If the table property
is more simple, i prefer to `create + table property` like trino.
If you think `create + table property` is also not friendly to users. I am
not against the currrent implementation. You just need to update the wiki doc
to tell users the create dialect for iceberg write order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
