ayushtkn commented on code in PR #5571:
URL: https://github.com/apache/hive/pull/5571#discussion_r1879650669
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -638,12 +638,12 @@ public enum ConfVars {
"hive.txn.acid.metrics.delta.pct.threshold", 0.01f,
"Percentage (fractional) size of the delta files relative to the base
directory. Deltas smaller than this threshold " +
"count as small deltas. Default 0.01 = 1%.)"),
- COMPACTOR_INITIATOR_ON("metastore.compactor.initiator.on",
"hive.compactor.initiator.on", false,
+ COMPACTOR_INITIATOR_ON("metastore.compactor.initiator.on",
"hive.compactor.initiator.on", true,
"Whether to run the initiator thread on this metastore instance or
not.\n" +
"Set this to true on one instance of the Thrift metastore service
as part of turning\n" +
"on Hive transactions. For a complete list of parameters required
for turning on\n" +
"transactions, see hive.txn.manager."),
- COMPACTOR_CLEANER_ON("metastore.compactor.cleaner.on",
"hive.compactor.cleaner.on", false,
+ COMPACTOR_CLEANER_ON("metastore.compactor.cleaner.on",
"hive.compactor.cleaner.on", true,
Review Comment:
If you set it to `true` all the HMS instances will have it turned on, maybe
that ain't the intention of this PR, IIRC we usually enable cleaner only on one
HMS instance not all, which post this change will be enabled on all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
