zratkai commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1904119389
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -14444,6 +14453,22 @@ ASTNode analyzeCreateTable(
return null;
}
+ private void checkSortCols(List<Order> sortCols, StorageFormat
storageFormat) throws SemanticException{
+
if("org.apache.iceberg.mr.hive.HiveIcebergStorageHandler".equalsIgnoreCase(storageFormat.getStorageHandler())){
Review Comment:
Not relevant anymore.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -281,6 +281,11 @@ enum DatabaseType {
REMOTE = 2
}
+enum NullOrderingType {
Review Comment:
Not relevant anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
