deniskuzZ commented on code in PR #5603:
URL: https://github.com/apache/hive/pull/5603#discussion_r1914350920
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MRCompactor.java:
##########
@@ -571,11 +571,9 @@ public void readFields(DataInput dataInput) throws
IOException {
attemptId = Integer.valueOf(attemptIdString);
}
deltasToAttemptId.put(deltas[i].getName(), attemptId);
- if (baseAttemptId != null) {
- deltasToAttemptId.put(base.getName(), baseAttemptId);
- }
}
if (baseAttemptId != null) {
+ deltasToAttemptId.put(base.getName(), baseAttemptId);
deltasToAttemptId.put(base.toString(), baseAttemptId);
Review Comment:
nice! I think using `name` is a better approach (it would be consistent for
base and deltas). Executed `TestCompactor` tests, all passed.
It seems that the code branch that was deleted, was accidentally added into
a delta elem loop during merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
