armitage420 commented on code in PR #5539:
URL: https://github.com/apache/hive/pull/5539#discussion_r1915350261
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/formatter/ShowTableStatusFormatter.java:
##########
@@ -89,7 +93,18 @@ List<Path> getLocations(Hive db, Partition partition, Table
table) throws HiveEx
List<Path> locations = new ArrayList<Path>();
if (table.isPartitioned()) {
if (partition == null) {
- for (Partition currPartition : db.getPartitions(table)) {
+ List<Partition> partitions;
+ GetProjectionsSpec getProjectionsSpec = new
GetPartitionProjectionsSpecBuilder()
+ .addProjectFieldList(Arrays.asList("sd.location")).build();
+ GetPartitionsRequest request = new
GetPartitionsRequest(table.getDbName(), table.getTableName(),
getProjectionsSpec, null);
Review Comment:
I am a bit skeptical about adding the new constructor for this use-case, as
the code complexity approximately would be the same here.
GetPartitionsRequestBuilder was built so that we would not have to write
multiple set_methods for our projections,
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/formatter/ShowTableStatusFormatter.java:
##########
@@ -89,7 +93,18 @@ List<Path> getLocations(Hive db, Partition partition, Table
table) throws HiveEx
List<Path> locations = new ArrayList<Path>();
if (table.isPartitioned()) {
if (partition == null) {
- for (Partition currPartition : db.getPartitions(table)) {
+ List<Partition> partitions;
+ GetProjectionsSpec getProjectionsSpec = new
GetPartitionProjectionsSpecBuilder()
+ .addProjectFieldList(Arrays.asList("sd.location")).build();
+ GetPartitionsRequest request = new
GetPartitionsRequest(table.getDbName(), table.getTableName(),
getProjectionsSpec, null);
Review Comment:
I am a bit skeptical about adding the new constructor for this use-case, as
the code complexity approximately would be the same here.
GetPartitionsRequestBuilder was built so that we would not have to write
multiple set_methods for our projections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
