InvisibleProgrammer commented on code in PR #5610:
URL: https://github.com/apache/hive/pull/5610#discussion_r1916180709
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HivePreWarmProcessor.java:
##########
@@ -86,7 +86,7 @@ public void run(Map<String, LogicalInput> inputs,
ReadaheadPool rpool = ReadaheadPool.getInstance();
ShimLoader.getHadoopShims();
- URL hiveurl = new URL("jar:file:" +
DagUtils.getInstance().getExecJarPathLocal(conf) + "!/");
Review Comment:
I assume it had something like that: `jar:file:file:/...` as
`getExecJarPathLocal` returns with a String created from an URL object, by
default.
The interesting thing is what happens when it falls back to hive config
(second part of the method). In that case, it just picks up anything that it
finds in the config. So, if the config currently contains a pattern like
`file:/...` then it will start working and didn't work before. But if the
config currently is `/...` then it will break the existing configuration.
I don't know if we have tests that test those cases or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
