kasakrisz commented on code in PR #5505: URL: https://github.com/apache/hive/pull/5505#discussion_r1922177485
########## ql/src/test/queries/clientpositive/reducesink_dedup.q: ########## @@ -1,3 +1,4 @@ +-- SORT_QUERY_RESULTS --! qt:dataset:part --! qt:dataset:src select p_name Review Comment: The RS operator has an order key because of the sort by. `sort by 1` means * when CBO is on: the sort key is the 1st column in the projection of the query. * when CBO is off: there is no sort key. I think this is a bug. I added `SORT_QUERY_RESULTS` because `sort by` does not guarantee a global order and the result may differ in subsequent executions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
