deniskuzZ commented on code in PR #5613: URL: https://github.com/apache/hive/pull/5613#discussion_r1931070141
########## ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/AbstractQueryHistoryRepository.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.queryhistory.repository; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.TableType; +import org.apache.hadoop.hive.metastore.api.Database; +import org.apache.hadoop.hive.metastore.api.FieldSchema; +import org.apache.hadoop.hive.metastore.api.hive_metastoreConstants; +import org.apache.hadoop.hive.ql.metadata.Hive; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.metadata.Table; +import org.apache.hadoop.hive.ql.parse.PartitionTransform; +import org.apache.hadoop.hive.ql.parse.TransformSpec; +import org.apache.hadoop.hive.ql.queryhistory.schema.QueryHistorySchema; +import org.apache.hadoop.hive.ql.session.SessionStateUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.base.Preconditions; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; + +public abstract class AbstractQueryHistoryRepository implements QueryHistoryRepository { + protected Logger LOG = LoggerFactory.getLogger(getClass()); + @VisibleForTesting + HiveConf conf; + protected QueryHistorySchema schema; + + public void init(HiveConf conf, QueryHistorySchema schema) { + this.conf = conf; + this.schema = schema; + + try (Hive hive = Hive.get(conf)) { + Database database = initDatabase(hive); + Table table = initTable(hive, database); + postInitTable(table); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + protected Database initDatabase(Hive hive) { + Database db; + try { + db = hive.getDatabase(QUERY_HISTORY_DB_NAME); + if (db == null) { + LOG.warn("Database ({}) for query history table hasn't been found, auto-creating one", QUERY_HISTORY_DB_NAME); + String location = getDatabaseLocation(QUERY_HISTORY_DB_NAME); + db = new Database(QUERY_HISTORY_DB_NAME, QUERY_HISTORY_DB_COMMENT, + location, null); + hive.createDatabase(db, false); + } + return db; + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + private String getDatabaseLocation(String databaseName) { + String warehouseLocation = conf.get(HiveConf.ConfVars.HIVE_METASTORE_WAREHOUSE_EXTERNAL.varname); + if (warehouseLocation == null) { + warehouseLocation = conf.get(HiveConf.ConfVars.METASTORE_WAREHOUSE.varname); + } + Preconditions.checkNotNull( + warehouseLocation, "Warehouse location is not set: 'hive.metastore.warehouse.external.dir' and " + + "'hive.metastore.warehouse.dir' are both null"); + return String.format("%s/%s.db", warehouseLocation, databaseName.toLowerCase()); + } + + protected Table initTable(Hive hive, Database db) { + Table table; + try { + table = hive.getTable(QUERY_HISTORY_DB_NAME, QUERY_HISTORY_TABLE_NAME, null, false); + if (table == null) { + LOG.info("Query history table ({}) isn't created yet", QUERY_HISTORY_TABLE_NAME); + table = createTable(hive, db); + } + return table; + } catch (HiveException e) { + throw new RuntimeException(e); + } + } + + protected abstract void postInitTable(Table table) throws Exception; + + /** + * Supposed to create the query history table in metastore. It's only called from + * initTable if it doesn't exist yet. + */ + protected abstract Table createTable(Hive hive, Database db) throws HiveException; + + /** + * While creating the table, getInitialTable is supposed to return a common table object, + * which contains anything general that's not specific to QueryHistoryRepository subclasses. + */ + protected Table getInitialTable() { Review Comment: `createTableObject()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
