armitage420 commented on code in PR #5584: URL: https://github.com/apache/hive/pull/5584#discussion_r1932391799
########## ql/src/test/results/clientpositive/llap/json_serde3.q.out: ########## @@ -131,7 +143,7 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@json_serde3_2 #### A masked pattern was here #### -2 FALSE NULL TRUE 1.23E45 value --2 false NULL true 1.23E45 value +-2 false NULL true 1.23E+45 value Review Comment: Just mentioning this here that, the `E` to `E+` transformation is done during the time jackson parser creates a jsonNode using json text/inputStream even before hitting the cases for `BINARY` or any other datatype to parse our particular json value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
