deniskuzZ commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932478595
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionUtil.java:
##########
@@ -94,4 +105,48 @@ public static List<DeleteFile> getDeleteFiles(Table table,
String partitionPath)
return
Lists.newArrayList(CloseableIterable.transform(filteredDeletesScanTasks,
t -> ((PositionDeletesScanTask) t).file()));
}
+
+ /**
+ * Returns target file size as following:
+ * In case of Minor compaction:
+ * 1. When COMPACTION_FILE_SIZE_THRESHOLD is defined, returns it.
Review Comment:
1. If `COMPACTION_FILE_SIZE_THRESHOLD` is supplied in compaction request,
returns it.
2. Otherwise, calculates the file size threshold as:
`HiveConf.COMPACTION_FILE_SIZE_THRESHOLD` * ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
