ayushtkn commented on code in PR #5500:
URL: https://github.com/apache/hive/pull/5500#discussion_r1941147880
##########
itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java:
##########
@@ -106,6 +106,8 @@ private void setUpFixtures(HiveConf conf) throws Exception {
"org.apache.hadoop.hbase.shaded.");
Configuration hbaseConf = HBaseConfiguration.create(conf);
+ // A workaround for HBASE-28908
+ hbaseConf.set("hbase.wal.provider", "filesystem");
Review Comment:
can you create a Hive ticket to upgrade HBase to 2.7.0. & link the mentioned
ticket + this line to be removed + HBASE-28939
##########
itests/hcatalog-unit/pom.xml:
##########
@@ -357,23 +357,4 @@
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
- <!-- See HIVE-24473 -->
Review Comment:
Why are we removing these?
##########
pom.xml:
##########
@@ -140,10 +140,10 @@
<guava.version>22.0</guava.version>
<groovy.version>2.4.21</groovy.version>
<h2database.version>2.2.220</h2database.version>
- <hadoop.version>3.3.6</hadoop.version>
+ <hadoop.version>3.4.1</hadoop.version>
<hadoop.bin.path>${basedir}/${hive.path.to.root}/testutils/hadoop</hadoop.bin.path>
<hamcrest.version>1.3</hamcrest.version>
- <hbase.version>2.5.6-hadoop3</hbase.version>
+ <hbase.version>2.5.10-hadoop3</hbase.version>
Review Comment:
The HBase upgrade can be split into another ticket unless it can't go ahead
without Hadoop upgade. If it is the case maybe then we can change the title to
show that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
