okumin commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r1942938896
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5839,13 +5840,30 @@ public HiveMetaHook getHook(
}
};
+ if ("rest".equals(conf.get("metastore.type", "hms"))) {
+ return getHiveIcebergRESTCatalog(conf);
+ }
+
if (conf.getBoolVar(ConfVars.METASTORE_FASTPATH)) {
return new SessionHiveMetaStoreClient(conf, hookLoader, allowEmbedded);
} else {
return RetryingMetaStoreClient.getProxy(conf, hookLoader,
metaCallTimeMap,
SessionHiveMetaStoreClient.class.getName(), allowEmbedded);
}
}
+ private IMetaStoreClient getHiveIcebergRESTCatalog(HiveConf conf) throws
MetaException {
+ try {
+ Class<? extends IMetaStoreClient> handlerClass =
+ (Class<? extends IMetaStoreClient>)
+
Class.forName("org.apache.iceberg.hive.HiveIcebergRESTCatalogClientAdapter",
true, Utilities.getSessionSpecifiedClassLoader());
+ IMetaStoreClient restCatalogMetastoreClient =
ReflectionUtils.newInstance(handlerClass, conf);
+ restCatalogMetastoreClient.reconnect();
+ return restCatalogMetastoreClient;
Review Comment:
My PR has not reached any conclusion with which maintainers can agree. We
have to reconsidering how we integrate some session features such as tmp tables.
This is the summary and my prososal. I'd like to hear your opinions as my
recommendation is not aligned your PR
https://docs.google.com/document/d/1fFvB0DAXJvPYv27R8nLa3tOUT67-hY0owxBrDY-BxUA/edit?usp=sharing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
