zhangbutao commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950160888
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1796,8 +1796,6 @@ public enum ConfVars {
"hive.metastore.custom.database.product.classname", "none",
"Hook for external RDBMS. This class will be instantiated only when
" +
"metastore.use.custom.database.product is set to true."),
- HIVE_BLOBSTORE_SUPPORTED_SCHEMES("hive.blobstore.supported.schemes",
"hive.blobstore.supported.schemes", "s3,s3a,s3n",
Review Comment:
@cnauroth The property defined in HiveConf has other purposes, namely to
distinguish between hdfs and s3.
But the property in MetastoreConf is only used to optimize the s3 rpc call
in **Warehouse::getDnsPath**, and i think the optimization can be used both s3
and hdfs. So we can remove the property in MetastoreConf & no need to
distinguish between s3 and hdfs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
