henrib commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1950395535


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -304,8 +304,8 @@ static ThriftHiveMetastore.Iface 
callEmbeddedMetastore(Configuration conf) throw
     try {
       Class<?> clazz = Class.forName(HIVE_METASTORE_CLASS);
       //noinspection JavaReflectionMemberAccess
-      Method method = 
clazz.getDeclaredMethod(HIVE_METASTORE_CREATE_HANDLER_METHOD,
-          Configuration.class);
+      String methodName = MetastoreConf.getVar(conf, 
MetastoreConf.ConfVars.HMS_HANDLER_CREATE);
+      Method method = clazz.getDeclaredMethod(methodName,Configuration.class);

Review Comment:
   It allows specifying the alternate method 'newHMSRetryingLocalHandler' which 
wraps the normal handler into a retrying RetryingHMSHandler which is missing 
from the 'raw handler' (if I'm not mistaken).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to