difin commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1960737129
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PropertyServlet.java:
##########
@@ -331,41 +313,49 @@ private void runGet(HttpServletRequest request,
}
}
+ /**
+ * Single servlet creation helper.
+ */
+ private static class ServerBuilder extends ServletServerBuilder {
+ final int port;
+ final String path;
+ ServerBuilder(Configuration conf) {
+ super(conf);
+ port = MetastoreConf.getIntVar(conf,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PORT);
+ path = MetastoreConf.getVar(conf,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PATH);
+ }
+
+ @Override
+ protected String getServletPath() {
+ return path;
+ }
+
+ @Override
+ protected int getServerPort() {
+ return port;
+ }
+
+ @Override
+ protected HttpServlet createServlet() throws IOException {
Review Comment:
`IOException` is not thrown here.
IDE shows that it is not needed here and I verified that it compiles
successfully without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
