henrib commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1976680139
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PropertyServlet.java:
##########
@@ -331,42 +308,34 @@ private void runGet(HttpServletRequest request,
}
}
+ public static ServletServerBuilder.Descriptor createServlet(Configuration
configuration) {
+ try {
+ int port = MetastoreConf.getIntVar(configuration,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PORT);
+ String path = MetastoreConf.getVar(configuration,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PATH);
+ if (port >= 0 && path != null && !path.isEmpty()) {
+ ServletSecurity security = new ServletSecurity(configuration);
+ HttpServlet servlet = security.proxy(new
PropertyServlet(configuration));
+ return new ServletServerBuilder.Descriptor(port, path, servlet) {
+ @Override public String toString() {
+ return "HMS property";
Review Comment:
getServletName() is only valid after calling init() on the servlet instance
otherwise it throws an exception and I'd prefer the toString() method to be
idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
