abstractdog commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1977160682
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -285,6 +286,11 @@ default List<ColumnStatisticsObj>
getColStatistics(org.apache.hadoop.hive.ql.met
return null;
}
+ default AggrStats
getAggrColStatsFor(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
List<String> colNames,
Review Comment:
I think even if this might look obvious, we need javadoc for all methods in
this interface
can you summarize here also what happens for storagehandlers that don't
support this functionality
is this implemented only if canProvideColStatistics=true?
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -285,6 +286,11 @@ default List<ColumnStatisticsObj>
getColStatistics(org.apache.hadoop.hive.ql.met
return null;
}
+ default AggrStats
getAggrColStatsFor(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
List<String> colNames,
Review Comment:
I think even if this might look obvious, we need javadoc for all methods in
this interface
can you summarize here also what happens for storagehandlers that don't
support this functionality
is this typically implemented only if canProvideColStatistics=true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
