zabetak commented on code in PR #5661:
URL: https://github.com/apache/hive/pull/5661#discussion_r1977448216
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -140,17 +140,6 @@ public interface RawStore extends Configurable {
*/
boolean openTransaction();
- /**
- * Opens a new one or the one already created. Every call of this function
must
- * have corresponding commit or rollback function call.
- *
- * @param isolationLevel The transaction isolation level. Only possible to
set on the first call.
- * @return an active transaction
- */
- default boolean openTransaction(String isolationLevel) {
- throw new UnsupportedOperationException("Setting isolation level for this
Store is not supported");
- }
-
Review Comment:
`RawStore` is a user-facing (`metastore.rawstore.impl`) public interface so
removing this default method is a breaking change. I guess there are not many
users relying on this so it should be rather safe to drop it. However, I feel
that dropping support for transactions with `isolationLevel` should have its
own dedicated JIRA case unless its really tight to this fix.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -677,10 +656,6 @@ public boolean isActiveTransaction() {
*/
@Override
public void rollbackTransaction() {
- if (openTrasactionCalls < 1) {
Review Comment:
Can we come up with any kind of unit test that reproduces the starvation or
something else that demonstrates the necessity of this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
