okumin commented on code in PR #5668:
URL: https://github.com/apache/hive/pull/5668#discussion_r1978670594
##########
standalone-metastore/metastore-tools/pom.xml:
##########
@@ -35,8 +35,8 @@
<commons-math3.version>3.6.1</commons-math3.version>
<jetbrain-annotation.version>16.0.2</jetbrain-annotation.version>
<standalone.metastore.path.to.root>..</standalone.metastore.path.to.root>
- <junit.jupiter.version>5.6.2</junit.jupiter.version>
- <junit.vintage.version>5.6.2</junit.vintage.version>
+ <junit.jupiter.version>5.11.2</junit.jupiter.version>
+ <junit.vintage.version>5.11.2</junit.vintage.version>
Review Comment:
The intention looks good to me. I wonder why we have to specify the version
in both `standalone-metastore/pom.xml` and this file. Can we remove these
properties and inherit the dependency management settings of the parent project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
