deniskuzZ commented on code in PR #5648: URL: https://github.com/apache/hive/pull/5648#discussion_r1993558002
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ########## @@ -2157,7 +2180,7 @@ private Partition getPartitionImpl(org.apache.hadoop.hive.ql.metadata.Table tabl public List<String> getPartitionNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable, Map<String, String> partitionSpec) throws SemanticException { Table icebergTable = IcebergTableUtil.getTable(conf, hmsTable.getTTable()); - return IcebergTableUtil.getPartitionNames(icebergTable, partitionSpec, true); + return IcebergTableUtil.getPartitionNames(icebergTable, partitionSpec, false); Review Comment: yes, [get/show]Partitions by default should return ALL table partitions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org