abstractdog commented on code in PR #5649:
URL: https://github.com/apache/hive/pull/5649#discussion_r1993607884
##########
service/src/java/org/apache/hive/service/cli/CLIService.java:
##########
@@ -126,13 +126,14 @@ public synchronized void init(HiveConf hiveConf) {
}
private void applyAuthorizationConfigPolicy(HiveConf newHiveConf) throws
HiveException,
- MetaException {
+ MetaException, IOException {
// authorization setup using SessionState should be revisited eventually,
as
// authorization and authentication are not session specific settings
SessionState ss = new SessionState(newHiveConf);
ss.setIsHiveServerQuery(true);
SessionState.start(ss);
ss.applyAuthorizationPolicy();
+ ss.close();
Review Comment:
I agree that attaching a new session state to threadlocal without closing
the previous one could be a problem, but creating + closing that every time
properly might also be a problem from performance point of view (just taking a
look at how much code resides in SesssionState.close), so wherever reusing a
SessionState is possible, let's reuse, I guess having e.g.
HiveMaterializedViewsRegistry as the outer scope we can store the SessionState
as field reference and close it when HS2 is shut down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
